this post was submitted on 02 Oct 2026
85 points (96.7% liked)

Programming

28764 readers
452 users here now

Welcome to the main community in programming.dev! Feel free to post anything relating to programming here!

Cross posting is strongly encouraged in the instance. If you feel your post or another person's post makes sense in another community cross post into it.

Hope you enjoy the instance!

Rules

Rules

  • Follow the programming.dev instance rules
  • Keep content related to programming in some way
  • If you're posting long videos try to add in some form of tldr for those who don't want to watch videos

Wormhole

Follow the wormhole through a path of communities !webdev@programming.dev



founded 3 years ago
MODERATORS
 

In a well-fleshed-out post, Scott Chacon shows how unneecessary Git 3.0's move to replace SHA-1 with SHA-256 is.

all 24 comments
sorted by: hot top controversial new old
[–] JadedBlueEyes@programming.dev 12 points 6 days ago (1 children)

This post misses, uh, a few important things that get mentioned in the lobsters comments: https://lobste.rs/s/bytzgl/git_3_0_s_upcoming_sha_256_default_will_be

[–] Kajika@lemmy.ml 3 points 6 days ago (1 children)

Thanks for sharing.

Why didn't I know lobsters before? This look 1000 times better than HN... oh you can't join. Makes sense it isn't that known.

[–] outerspace@lemmy.zip 1 points 3 days ago

Can anyone share an invite please?

[–] Kajika@lemmy.ml 6 points 6 days ago* (last edited 6 days ago) (2 children)

It's sad to see this community only listening to people because they're rich: there are a lot of better engineers who knows more than this guy but they're not "co-creator of GitHub". I read this title as boot licking silicon valley.

That being said you don't hash git commits for security reason : YOU SIGN YOUR COMMITS FOR SECURITY. Sorry for the caps but let's make this visible.

[–] tetrislife@leminal.space 2 points 4 days ago

If you know of write-ups by others on this, you are welcome to share. It was a pretty long post, so I mentioned who authored it. If it was on, say, LWN, I wouldn't have prefixed anything to the topic. It looks like it also helps people to avoid rich-man blogs (if they want to)!

[–] Miaou@jlai.lu 1 points 5 days ago

But signing keys can be stolen, have to be updated, revoked etc. A secure hash is an elegant way to say "this repo contains what I want"

[–] enchanted@lemmy.world 27 points 1 week ago (3 children)

His defense of SHA-1:

Mathematically, for SHA-1’s 160-bit output, the birthday bound means that you would need about 1.4 septillion random files (1.4 quadrillion billion files - 1,400,000,000,000,000 billion - it's impossible to effectively describe) in a single project to have file hashes accidentally collide.

For the most part the article mostly talks about collision attacks, which quite frankly i think is silly.

He also talks about hashes pointing to other (older) projects using a different hashing algorithm, but can't the software just detect if its a SHA-1 hash or SHA-256, and fetch it accordingly? He acts like its the end of the world when in my mind most everything can (and probably will) be compensated for pretty easily. It's reminiscent of the IPv6 fear-mongering.

The thing that gets me is he doesn't say if the current hashing algorithm or the new one has any support for when hashes do collide. Since that can theoretically happen with both, to me that sounds like a problem worth tackling.

[–] panda_abyss@lemmy.ca 6 points 1 week ago (1 children)

I would have thought they’d prefix the hash with “sha256-“ or something, or even just 256 prefix the hash.

[–] setsubyou@lemmy.world 35 points 1 week ago

They have different fixed lengths, no prefix needed to tell them apart.

[–] jsnfwlr@lemmy.ml 3 points 1 week ago* (last edited 1 week ago)

Collision concerns make sense. If you manage to get two different files with the same hash, that will cause issues for your repo - the concerns over a collision justify the move to SHA-256 though.

[–] thenextguy@sh.itjust.works 24 points 1 week ago

Madness

We had a similar stupid issue at my last job. Someone made an edict that all Sha-1 and md5 references in the code must be removed for security reasons.

[–] JakenVeina@midwest.social 22 points 1 week ago (2 children)

There's people who seriously think commit hashes are there for security purposes? Furthermore, there are git MAINTAINERS that think this?

How absurd. Author is completely right, making SHA-256 the default implementation serves no purpose. SHA-1 is a completely valid algorithm for non-security use cases, which is precisely how git uses it. This is a solution looking for a problem.

I think he's maybe overblowing the impact of this change. Realistically, the only ones who are going to be impacted are the folks who maintain git-related tools and forges, as he mentions. The rest of us probably won't even notice. But that's still a ton of pointless work for those folks.

[–] atzanteol@sh.itjust.works 4 points 6 days ago

I think he's maybe overblowing the impact of this change.

Maybe... But I don't look forward to working with the dozens of IT folks at my company who all installed git once and have never upgraded. This will be multiple meetings, show up on slide decks, break builds...

It's going to be a right pain for nothing.

[–] asdfasdfasdf@lemmy.world 3 points 6 days ago* (last edited 6 days ago) (2 children)

Wait, they don't affect security? Wouldn't a hash collision mean pulling that hash from GitHub would pull wrong code? Or maybe delete code? I'd assume the hash is used as a lookup key in a database somewhere.

You also pin dependencies to specific hashes for security reasons.

[–] JakenVeina@midwest.social 5 points 6 days ago

The blog post lays it out pretty well.

The vulnerability of SHA-1 is that it's possible for an attacker to find colliding hashes. But that's not really an attack vector, because it's not like they can find aatching hash for just ANY input. In order to pull off an attack, using a hash collision, an attacker would have to already be trusted within the controlling system, in which case they can do a hell of a lot worse than swapping out a file.

Like you say, the hash is used as a lookup key within the git repo's database. The requirement for that is uniqueness, which SHA-1 still fulfills just fine. The trust isn't in the database lookup, the trust is in the systems that controls access to and distribution of that database.

As the article points out, Linus Torvalds himself said as much in 2005, when he first wrote git:

I really think people should not consider the sha1 the "security". The real security is in distribution.

[–] one_old_coder@piefed.social -1 points 4 days ago

If you need security, you must sign the commits.

[–] panda_abyss@lemmy.ca 14 points 1 week ago (2 children)

Why did they skip the 255 versions?!

/s

[–] BitUnWise@programming.dev 11 points 1 week ago

Don't be insane, they only skipped 254 versions

[–] Randelung@lemmy.world 8 points 1 week ago (1 children)
[–] one_old_coder@piefed.social 0 points 4 days ago* (last edited 4 days ago)

Every time I use the shitty command-line flags of git, there is a laugh track.

[–] one_old_coder@piefed.social 7 points 1 week ago (1 children)

I'm not qualified to talk about it but Hacker News has arguments against his post: https://news.ycombinator.com/item?id=49924179

[–] ISO@lemmy.zip 26 points 1 week ago

You're probably more qualified than most HNers, just less confident, less inclined to indulge in performative expertise and pseudo-intellectual posturing, and more resistant to joining the circle-jerks with those who do indulge.

[–] into_highest_invite@lemmygrad.ml 2 points 1 week ago* (last edited 1 week ago)

I pull it from there because I trust that GitHub has its authentication game together enough that it's unlikely that anyone malicious...

i don't. more importantly, my package manager doesn't. that is, every package manager i can think of references git commit hashes in its build system. the end user trusts that when they build from commit xxxxxxxx, they're getting the exact same code as everyone else. what exactly is being signed in these build systems i don't know, but whatever scott or linus or anyone else wishes would happen, in the real world, commit hashes are a part of the trust chain.

then again, a lot of package managers just use tags. so maybe in practice, they do trust microsoft.